Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10523] forward exceptions for un-expected response from ODP #488

Merged
merged 2 commits into from
Aug 20, 2024
Merged

[FSSDK-10523] forward exceptions for un-expected response from ODP #488

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c92f91
Null segment exception added
muzahidul-opti Aug 12, 2024
03a0394
disable testcases for 400 and 500 status code
muzahidul-opti Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions odp/src/main/java/com/optimizely/ab/android/odp/ODPSegmentClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,10 @@ open class ODPSegmentClient(private val client: ClientForODPOnly, private val lo
logger.debug("Successfully fetched ODP segments: {}", json)
return@Request json
} else {
logger.error("Unexpected response from ODP segment endpoint, status: $status")
return@Request null
var errMsg = "Unexpected response from ODP segment endpoint, status: $status"
logger.error(errMsg)
// return@Request null
throw Exception(errMsg)
}
} catch (e: Exception) {
logger.error("Error making ODP segment request", e)
Expand Down
Loading