Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10587] chore: rollback to 4.0.0 #491

Merged
merged 2 commits into from
Aug 23, 2024
Merged

[FSSDK-10587] chore: rollback to 4.0.0 #491

merged 2 commits into from
Aug 23, 2024

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Aug 22, 2024 •
edited
Loading

Summary

  • Rollback to 4.0.0

The "why", or other context.

Test plan

Issues

@muzahidul-opti muzahidul-opti marked this pull request as ready for review August 22, 2024 17:28
@muzahidul-opti muzahidul-opti requested a review from a team as a code owner August 22, 2024 17:28
@muzahidul-opti muzahidul-opti requested a review from jaeopt August 22, 2024 17:28
jaeopt
jaeopt requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like reverting 4.0.2 only, not 4.0.1.

@muzahidul-opti
Copy link
Contributor Author

It looks like reverting 4.0.2 only, not 4.0.1.

Oh, I thought only forwarding exception part should be updated.
So, we need to remove ClientForODPOnly class also, right?

@muzahidul-opti muzahidul-opti requested a review from jaeopt August 23, 2024 10:57
jaeopt
jaeopt approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! we can fix FSSDK-000 and confirm unit tests passed

@muzahidul-opti muzahidul-opti changed the title [FSSDK-0000] chore: rollback to 4.0.0 [FSSDK-10587] chore: rollback to 4.0.0 Aug 23, 2024
@muzahidul-opti muzahidul-opti merged commit d1aabb8 into master Aug 23, 2024
9 of 14 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/rollback-4.0.0 branch August 23, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @jaeopt