feat: Added GetFeatureVariableJSON. #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # OptimizelySDK.Tests/OptimizelyJsonTest.cs
| @@ -1624,7 +1704,7 @@ public void TestUnsupportedVariableType() | |||
| Assert.IsNull(featureVariableStringRandomType); | |||
|
|
|||
| var featureVariableStringJsonType = Optimizely.GetFeatureVariableString("unsupported_variabletype", "string_json_key", TestUserId); | |||
| Assert.AreEqual(featureVariableStringJsonType, "{\"myvalue\": \"jsonValue\"}"); | |||
| Assert.IsNull(featureVariableStringJsonType); | |||
There was a problem hiding this comment.
Why value is changed to IsNULL
There was a problem hiding this comment.
because the subtype of that variable is json and we are changing type from string to json upon initialization. so it will not match and will return null as type of variable will not match
msohailhussain
approved these changes
May 12, 2020
| @@ -589,6 +593,13 @@ | |||
| "key": "string_variable", | |||
| "type": "string", | |||
| "defaultValue": "wingardium leviosa" | |||
| }, | |||
There was a problem hiding this comment.
since C# had a problem before with json type, please add
{
"defaultValue": "{\"int_var\": 5212, \"boolean_key\": true}",
"type": "json",
"id": "1",
"key": "true_json_var"
}
and test
There was a problem hiding this comment.
Added the test you asked for. So can you please review if this is what you asked for? link
pawels-optimizely
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan