feat: Add Authenticated Datafile Support #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/optimizely/csharp-testapp/pull/65 |
There was a problem hiding this comment.
Minor comments. Will let @pawels-optimizely have the final say
| @@ -28,34 +28,64 @@ public class HttpProjectConfigManager : PollingProjectConfigManager | |||
| { | |||
| private string Url; | |||
| private string LastModifiedSince = string.Empty; | |||
|
|
|||
| private string AuthenticatedDatafileToken = string.Empty; | |||
There was a problem hiding this comment.
Call it datafileAuthToken
| private HttpProjectConfigManager(TimeSpan period, string url, TimeSpan blockingTimeout, bool autoUpdate, ILogger logger, IErrorHandler errorHandler) | ||
| : base(period, blockingTimeout, autoUpdate, logger, errorHandler) | ||
| { | ||
| Url = url; | ||
| } | ||
|
|
||
| private HttpProjectConfigManager(TimeSpan period, string url, TimeSpan blockingTimeout, bool autoUpdate, ILogger logger, IErrorHandler errorHandler, string authDatafileToken) |
pawels-optimizely
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Added new unit tests
FSC is passing here.
https://travis-ci.com/github/optimizely/fullstack-sdk-compatibility-suite/builds/171678195