Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Semantic version fix and multiple dash signs check added #242

Merged
merged 2 commits into from
Sep 8, 2020
Merged

fix: Semantic version fix and multiple dash signs check added #242

merged 2 commits into from
Sep 8, 2020

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Sep 3, 2020

Summary

  • Multiple fixed for sem-versioning
  • Compare build version and pre-release fix
  • Multiple - is now handled.

Test plan

All FSC tests must pass
Added unit tests

@mnoman09 mnoman09 requested a review from a team as a code owner September 3, 2020 16:34
@mnoman09 mnoman09 removed their assignment Sep 3, 2020
aliabbasrizvi
aliabbasrizvi reviewed Sep 8, 2020
View reviewed changes
OptimizelySDK/AudienceConditions/SemanticVersion.cs
{
return false;
}
return buildIndex < preReleaseIndex;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A unified IsPrereleaseOrBuild method may be slightly more performant. I'd recommend going down that path.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Sep 8, 2020
View reviewed changes
Copy link

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 38e82b2 into master Sep 8, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the mnoman/semverFix branch September 8, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi left review comments

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnoman09 @aliabbasrizvi @thomaszurkan-optimizely @optimizely-codereview-bot