Feat: Adds Decide All, DecideForKeys and track event #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and classes related to it
BugFix of userAttributes Unit tests fix
This reverts commit 6c9ac4d.
BugFix of userAttributes Unit tests fix
Added Unit tests of above functions
Throwing not implemented exceptions for not implemented functions in optimizelyUserContext Added detailed documentation of optimizelyUserContext and Decision class
# Conflicts: # OptimizelySDK.Tests/OptimizelyUserContextTest.cs # OptimizelySDK/OptimizelyUserContext.cs
# Conflicts: # OptimizelySDK/Optimizely.cs
# Conflicts: # OptimizelySDK/OptimizelyUserContext.cs
added check of decisionReason in test that it should be zero if no error log occurs
jaeopt
requested changes
Dec 3, 2020
# Conflicts: # OptimizelySDK.Tests/OptimizelyDecisions/OptimizelyDecisionTest.cs # OptimizelySDK.Tests/OptimizelyUserContextTest.cs # OptimizelySDK/Optimizely.cs # OptimizelySDK/OptimizelyDecisions/DefaultDecisionReasons.cs # OptimizelySDK/OptimizelyUserContext.cs
OptimizelySDK/Optimizely.cs
Outdated
| private OptimizelyDecideOption[] GetAllOptions(OptimizelyDecideOption[] options) | ||
| { | ||
| OptimizelyDecideOption[] copiedOptions = new OptimizelyDecideOption[DefaultDecideOptions.Length]; | ||
| Array.Copy(DefaultDecideOptions, copiedOptions, DefaultDecideOptions.Length); | ||
| if (options != null) | ||
| { | ||
| copiedOptions.Concat(options); | ||
| copiedOptions = copiedOptions.Concat(options).Concat(DefaultDecideOptions).ToArray(); |
There was a problem hiding this comment.
Can you please try, it's just an improvement.
return = options.Union(DefaultDecideOptions).ToArray();
msohailhussain
approved these changes
Dec 8, 2020
…DecideOptions).ToArray();
with
copiedOptions = options.Union(DefaultDecideOptions).ToArray();
# Conflicts: # OptimizelySDK.Tests/OptimizelyUserContextTest.cs # OptimizelySDK/Optimizely.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan