Feat: added SDKkey and environment key in project config #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,6 +69,16 @@ public enum OPTLYSDKVersion | |||
| /// </summary> | |||
| public string Revision { get; set; } | |||
|
|
|||
| /// <summary> | |||
| /// SDK key of the dataflie. | |||
There was a problem hiding this comment.
typo.
SDK Key of the datafile for specific environment.
| public string SDKKey { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Environment key of the dataflie. |
| public IDictionary<string, OptimizelyExperiment> ExperimentsMap { get; private set; } | ||
| public IDictionary<string, OptimizelyFeature> FeaturesMap { get; private set; } | ||
|
|
||
| private string _datafile; | ||
|
|
||
| public OptimizelyConfig(string revision, IDictionary<string, OptimizelyExperiment> experimentsMap, IDictionary<string, OptimizelyFeature> featuresMap, string datafile = null) | ||
| public OptimizelyConfig(string revision, string sdkKey, string environmentKey, IDictionary<string, OptimizelyExperiment> experimentsMap, IDictionary<string, OptimizelyFeature> featuresMap, string datafile = null) |
There was a problem hiding this comment.
This will break functionality.
Add one more constructor and leave this constructor as it is.
OptimizelySDK/ProjectConfig.cs
Outdated
| @@ -44,6 +44,15 @@ public interface ProjectConfig | |||
| /// </summary> | |||
| string Revision { get; set; } | |||
|
|
|||
| /// <summary> | |||
| /// SDK key of the dataflie. | |||
OptimizelySDK/ProjectConfig.cs
Outdated
| string SDKKey { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Environment key of the dataflie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All unit tests and FSC tests should pass