Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typed audiences should take priority. #273

Merged
merged 2 commits into from
Aug 5, 2021
Merged

fix: typed audiences should take priority. #273

merged 2 commits into from
Aug 5, 2021

Conversation

msohailhussain
Copy link
Contributor

Summary

  • Typed audiences should be taken priority, if any audienceId is same in audiences and typedAudiences, typedAudiences should be considered.

Test plan

  • Updated unit test and FSC should be passed with new testcases.

@msohailhussain msohailhussain marked this pull request as ready for review August 5, 2021 17:27
@msohailhussain msohailhussain requested a review from a team as a code owner August 5, 2021 17:27
@msohailhussain msohailhussain requested a review from jaeopt August 5, 2021 17:27
@msohailhussain msohailhussain removed their assignment Aug 5, 2021
@The-inside-man
Copy link

LGTM - Just noting the FSC failure due to the FSC fix not merged yet. Noted that is the only reason it is failing.

jaeopt
jaeopt approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msohailhussain
Copy link
Contributor Author

PR is passing.
https://travis-ci.com/github/optimizely/fullstack-sdk-compatibility-suite/builds/234629631

@jaeopt jaeopt merged commit 865dab3 into master Aug 5, 2021
@jaeopt jaeopt deleted the sohail/ta_prio_fix branch August 5, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@The-inside-man The-inside-man The-inside-man approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msohailhussain @The-inside-man @jaeopt