Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: experimentRules should have same order as experimentIds #279

Merged
merged 5 commits into from
Sep 2, 2021

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Sep 1, 2021

Summary

  • ExperimentRules sequence critically important when evaluating for decision. it should follow experimentIds under featureFlag object sequence.
  • Updated ci to xenial since trusty has no more dotnet version.
  • Updated mono & dotnet-sdk versions which were quite old.

Test plan

  • We have test cases in FSC, must pass for unsorted scenarios.

@msohailhussain msohailhussain marked this pull request as ready for review September 1, 2021 21:51
@msohailhussain msohailhussain requested a review from a team as a code owner September 1, 2021 21:51
@msohailhussain msohailhussain reopened this Sep 1, 2021
@msohailhussain msohailhussain removed their assignment Sep 1, 2021
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm the exp ordering?

Comment on lines 230 to 231
var featureExperimentMap = featureFlag.ExperimentIds.Select(experimentId => experimentsMapById[experimentId])
.ToDictionary(experiment => experiment.Key, experiment => experiment);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like losing order here - it picks up experimentIds as an array, but sets to map immediately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i have run multiple times with unsorted scenario and works fine.

@msohailhussain msohailhussain removed their assignment Sep 1, 2021
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dustin-sier dustin-sier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really appreciate that change for both the feature map and the experiment rules, much easier to work forward from.

@msohailhussain msohailhussain merged commit 34a74cb into master Sep 2, 2021
@msohailhussain msohailhussain deleted the mnoman/OptlyConfigv2Fix branch September 2, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants