-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ODP GraphQL Manager and Tests #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some suggestions for error handling.
I see some C# stuffs I cannot review. Let Sohail double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Some more suggestions regarding error handling.
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should I wait until @msohailhussain reviews? |
@mikechu-optimizely Yes, let's wait for his review. |
Hopefully, I've not ruined your codebase with this PR @msohailhussain 😁 |
@msohailhussain when you have a chance, this PR also needs your 👍 Thanks! |
# Conflicts: # OptimizelySDK.Tests/OptimizelySDK.Tests.csproj # OptimizelySDK/OptimizelySDK.csproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before merge, please discuss GetAwaiter with me.
Summary
Test plan
Issues