Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: return method doc for IsFeatureEnabled #329

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Fix for incorrect documentation on Optimizely.IsFeatureEnabled

Test plan

  • Existing unit and FSC test should pass

Issues

  • FSSDK-9999 just kidding it's for DOC-2699 but had to satisfy the check 😉

@trishahanlon
Copy link
Collaborator

LGTM!

@mikechu-optimizely mikechu-optimizely merged commit ec0ce66 into master Feb 22, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/IsFeatureEnabled-doc-fix branch February 22, 2023 18:49
mnoman09 added a commit that referenced this pull request Mar 16, 2023
* chore : updated prefix of ticket-check action (#314)

(cherry picked from commit 678c6fd)

* chore: Fix and Reconfigure GitHub Actions (#319)

* Fix <return> method doc for IsFeatureEnabled (#329)

* [FSSDK-8938] chore: Updated newtonsoft.Json version and NjsonSchema version (#330)

* [FSSDK-8955] Refac: Replaced all instances of full stack except from changelog file and code files (#331)

* Replaced all instances of full stack except from changelog file and code files

Co-authored-by: Griffin Cox <104227910+griffincox-optimizely@users.noreply.github.com>

* [FSSDK-8955] Do not lint markdown for now

* [FSSDK-8955] Remove VALIDATE_MARKDOWN

---------

Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com>
Co-authored-by: Griffin Cox <104227910+griffincox-optimizely@users.noreply.github.com>
Co-authored-by: Mike Chu <michael.chu@optimizely.com>
(cherry picked from commit 5f16357)
(cherry picked from commit 887166e)

* [FSSDK-8955] Refac: Replaced all instances of full stack  from code comments and in nuspec except owner. (#332)

(cherry picked from commit 2a5b19c)

* [FSSDK-8955] chore: prepare for release 3.11.2 (#333)

* [FSSDK-8955] chore: prepare for release 3.11.2

* Nit fixed

---------

Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com>
(cherry picked from commit e620c08)

* updated release date to 16th March

---------

Co-authored-by: Muhammad Shaharyar <shairy333@gmail.com>
Co-authored-by: Mike Chu <104384559+mikechu-optimizely@users.noreply.github.com>
Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants