Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10265] fix: UPS Lookup & Save during batched Decide #375

Merged
merged 28 commits into from
Nov 6, 2024
Merged

[FSSDK-10265] fix: UPS Lookup & Save during batched Decide #375

merged 28 commits into from
Nov 6, 2024

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Oct 18, 2024 •
edited
Loading

Summary

  • User Profile Service should only Lookup and Save once when using DecideAll and DecideForKeys.
  • CI updates to Action versions & to prevent building when PR is in Draft
  • CD updates to
    • bump Action versions
    • create new deployment strategy around a remote signing server
    • add gated publish to Nuget

Test plan

  • Existing and new unit tests should pass
  • FSC should pass

Issues

  • FSSDK-10265
  • FSSDK-9976

@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review October 22, 2024 21:31
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner October 22, 2024 21:31
@mikechu-optimizely mikechu-optimizely marked this pull request as draft October 22, 2024 21:32
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review October 22, 2024 21:37
@mikechu-optimizely mikechu-optimizely marked this pull request as draft October 22, 2024 21:42
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review October 22, 2024 21:43
@mikechu-optimizely mikechu-optimizely marked this pull request as draft October 22, 2024 21:48
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review October 22, 2024 21:49
raju-opti
raju-opti approved these changes Oct 29, 2024
View reviewed changes
Copy link

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikechu-optimizely
Copy link
Contributor Author

mikechu-optimizely commented Nov 1, 2024 •
edited
Loading

Temporary close

@mikechu-optimizely
Copy link
Contributor Author

Based on our team call, I'm bypassing the 6 failing e2e tests (common thread: null is provided as an input parameter) and merging this change.

@mikechu-optimizely mikechu-optimizely merged commit 50624fb into master Nov 6, 2024
9 of 10 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/FSSDK-10265-ups-batch-decide-inversion branch November 6, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-opti raju-opti raju-opti approved these changes

@jaeopt jaeopt Awaiting requested review from jaeopt

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikechu-optimizely @raju-opti