feat: Experiment override service #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
October 29, 2019 14:21
… NewCompositeService
mikeproeng37
suggested changes
Nov 4, 2019
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
Implementation looks great! I have some suggestions
| if variation.Key == variationKey { | ||
| decision.Variation = &variation | ||
| decision.Reason = reasons.OverrideVariationAssignmentFound | ||
| eosLogger.Info(fmt.Sprintf("Override variation %v found for user %v", variationKey, userContext.ID)) |
Contributor
There was a problem hiding this comment.
I think this should be a debug level message
| return decision, nil | ||
| } | ||
|
|
||
| // TODO(Matt): Add a VariationsByKey map to the Experiment struct, and use it to look up Variation by key |
Contributor
There was a problem hiding this comment.
Probably a keyToID map and then you can just look up by ID
| return decision, nil | ||
| } | ||
|
|
||
| // TODO(Matt): Add a VariationsByKey map to the Experiment struct, and use it to look up Variation by key |
Contributor
There was a problem hiding this comment.
is this TODO still needed ?
Contributor
Author
There was a problem hiding this comment.
I think it's needed. Ideally we would not have to iterate over variations to find the one with a given key.
mikeproeng37
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
ExperimentOverrideService, a decision service that can pull variations from anExperimentOverrideStore, which is an interface that returns variations for experiment key/user ID pairs.Included is an implementation of
ExperimentOverrideStorebased on a map.Test plan
New unit tests
JIRA Issues
https://optimizely.atlassian.net/browse/OASIS-5419