Skip to content

fix(audience-conditions): fixed parsing for audience conditions. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 5, 2019
Merged

fix(audience-conditions): fixed parsing for audience conditions. #165

merged 7 commits into from
Nov 5, 2019

Conversation

@yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Nov 4, 2019

Summary

  • Fixed audienceConditions parsing when a leaf is provided instead of an array in the datafile.

@yasirfolio3 yasirfolio3 requested a review from a team as a code owner November 4, 2019 08:48
@yasirfolio3 yasirfolio3 mentioned this pull request Nov 4, 2019
Merged
mikeproeng37
mikeproeng37 suggested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a unit test to capture the regression

@yasirfolio3
Copy link
Contributor Author

yasirfolio3 commented Nov 5, 2019

Let's add a unit test to capture the regression

Unit test added, thanks.

@mikeproeng37 mikeproeng37 merged commit 9c082a9 into master Nov 5, 2019
@mikeproeng37 mikeproeng37 deleted the yasir/audienceconditions-fix branch November 5, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yasirfolio3 yasirfolio3

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yasirfolio3 @mikeproeng37