Skip to content

fix: return right after datafile getter returns an error (don't parse garbage) #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

fix: return right after datafile getter returns an error (don't parse garbage) #170

merged 1 commit into from
Nov 7, 2019

Conversation

@pawels-optimizely
Copy link
Contributor

@pawels-optimizely pawels-optimizely commented Nov 7, 2019

@pawels-optimizely pawels-optimizely requested a review from a team as a code owner November 7, 2019 21:37
mikeproeng37
mikeproeng37 approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pawels-optimizely pawels-optimizely merged commit 56b8e59 into master Nov 7, 2019
@pawels-optimizely pawels-optimizely deleted the pawel/OASIS-5597 branch November 7, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely Awaiting requested review from thomaszurkan-optimizely

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pawels-optimizely pawels-optimizely

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawels-optimizely @mikeproeng37