refact(audience-evaluation): Fixed null-bubbling issues. #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasirfolio3
changed the title
mikeproeng37
suggested changes
Nov 14, 2019
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
lgtm for the most part. Could you please have a link to passing FSC tests that includes the advanced audience targeting?
| // This wrapper method converts the conditionEvalResult to a boolean | ||
| result, _ := c.evaluate(node, condTreeParams) | ||
| return result | ||
| return c.evaluate(node, condTreeParams) |
Contributor
There was a problem hiding this comment.
We don't need this wrapper method anymore right? Can we simply rename c.evaluate to c.Evaluate?
mikeproeng37
approved these changes
Nov 15, 2019
| return fmt.Errorf("Invalid response for dispatched Events") | ||
| } | ||
|
|
||
| // Sort's attributes under visitors which is required for subset comparison of attributes array |
Contributor
There was a problem hiding this comment.
nit: Sorts, no apostrophe
Contributor
mjc1283
reviewed
Nov 16, 2019
| AudienceMap: audienceMap, | ||
| } | ||
| result = conditionTreeEvaluator.Evaluate(audienceTree, treeParams) | ||
| result, _ = conditionTreeEvaluator.Evaluate(audienceTree, treeParams) |
Contributor
There was a problem hiding this comment.
Do we need to add any test cases that involve the second return value from conditionTreeEvaluator.Evaluate?
@mikeng13 @msohailhussain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
leaf node evaluationerrors were ignored andgatessuch asnotwere able to perform operations on the result ofinvalid leaf node evaluation.