Skip to content

Conversation

@mikecdavis
Copy link
Contributor

Summary

  • Reverts signature changes for PollingProjectConfigManager
  • Store sdkKey on the PollingProjectConfigManager

A recent PR #195 broke backwards compatibility and added potential internal discrepancies of the current SDK. This change ensures that the SDK key used to initialize the Config Manager is used consistently throughout its lifecycle.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikecdavis mikecdavis merged commit 973644b into master Dec 4, 2019
@mikecdavis mikecdavis deleted the mikecdavis/fix-polling-config-manager branch December 4, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants