refac(config): Move config interfaces back into config package #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawels-optimizely
suggested changes
Dec 9, 2019
Contributor
pawels-optimizely
left a comment
pawels-optimizely
left a comment
There was a problem hiding this comment.
please organize imports and fix travis tests (linters)
mikecdavis
approved these changes
Dec 10, 2019
Contributor
mikecdavis
left a comment
mikecdavis
left a comment
There was a problem hiding this comment.
Let's find a better home for version.go as well. Other than that, LGTM!
|
|
||
| // Package pkg // | ||
| package pkg | ||
| package config |
Contributor
There was a problem hiding this comment.
Probably not the intended file name change :)
Contributor
There was a problem hiding this comment.
...referring to interface.go.go
pkg/event/factory.go
Outdated
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "github.com/optimizely/go-sdk/pkg/config" |
Contributor
There was a problem hiding this comment.
pkg is still being required. We should probably move version.go as well.
pawels-optimizely
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pkgintoconfigso we don't have anything hanging off of thepkgpackage.Tests