fix(notification): race detected send notification issue #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func (am *AtomicManager) Send(notification interface{}) { | ||
| for _, handler := range am.handlers { | ||
| handlers := am.copyHandlers() | ||
| for _, handler := range handlers { |
Contributor
There was a problem hiding this comment.
instead of copying everything at once, can we just do handler := handler inside the for loop ?
Contributor
Author
There was a problem hiding this comment.
tried didn't work.
mikeproeng37
reviewed
Jan 3, 2020
pkg/notification/manager.go
Outdated
| @@ -1,5 +1,5 @@ | |||
| /**************************************************************************** | |||
| * Copyright 2019, Optimizely, Inc. and contributors * | |||
| * Copyright 2019-2020, Optimizely, Inc. and contributors * | |||
Contributor
There was a problem hiding this comment.
Haha it's 2020! Still hasn't sunk in yet
pkg/notification/manager.go
Outdated
| for _, handler := range am.handlers { | ||
| handlers := am.copyHandlers() | ||
| for _, handler := range handlers { | ||
| // copying handler to avoid race condition |
Contributor
There was a problem hiding this comment.
Move this comment to right before we copy handlers
mikeproeng37
approved these changes
Jan 3, 2020
pkg/notification/manager.go
Outdated
| } | ||
| } | ||
|
|
||
| // Copy handlers and return it. |
Contributor
There was a problem hiding this comment.
nit: Return a copy of the given handlers
mikecdavis
approved these changes
Jan 3, 2020
Contributor
mikecdavis
left a comment
mikecdavis
left a comment
There was a problem hiding this comment.
Minor comment to copy to a list since we don't need the map interface.
pkg/notification/manager.go
Outdated
Comment on lines
85
to
93
| func (am *AtomicManager) copyHandlers() map[uint32]func(interface{}) { | ||
| am.lock.RLock() | ||
| defer am.lock.RUnlock() | ||
| m := make(map[uint32]func(interface{}), len(am.handlers)) | ||
| for k, v := range am.handlers { | ||
| m[k] = v | ||
| } | ||
| return m | ||
| } |
Contributor
There was a problem hiding this comment.
We don't really need a map. We can simply copy to a list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestPlan