feat: Add observability metrics for event queue #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
previously requested changes
Jan 3, 2020
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
Nice! I like this generic approach way better. I've added a few comments in there.
mikecdavis
reviewed
Jan 3, 2020
mikecdavis
suggested changes
Jan 7, 2020
Contributor
mikecdavis
left a comment
mikecdavis
left a comment
There was a problem hiding this comment.
This looks great! I have a few naming suggestion and would prefer we restore the test assertions, but overall it's looking spot on.
mjc1283
reviewed
Jan 8, 2020
Comment on lines
+77
to
+79
| sucessFlush metrics.Counter | ||
| failFlushCounter metrics.Counter | ||
| retryFlushCounter metrics.Counter |
Contributor
There was a problem hiding this comment.
Two of these fields have Counter in the field name, but one doesn't - seems weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary