feat: set specific error from default project config manager when CDN returns 403 response #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… returns 403 response
pkg/config/polling_manager.go
Outdated
| const DatafileURLTemplate = "https://cdn.optimizely.com/datafiles/%s.json" | ||
|
|
||
| // Err403Forbidden is 403Forbidden specific error | ||
| var Err403Forbidden = errors.New("unable to fetch fresh datafile, reason (http status code): 403 Forbidden") |
Contributor
There was a problem hiding this comment.
It will be good to mention that people confirm their SDK key again.
On most occasions the 403 error will happen from people providing inaccurate SDK key.
aliabbasrizvi
approved these changes
Jan 17, 2020
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
Please include a PR summary with this PR. Otherwise looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assigning error to a predefined error variable when CDN returns 403 response helps consumers such as sidedoor. Currently these consumers have to search the error message string for the text "403", which is not really convenient.