feat: add valid datafile version check #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawels-optimizely
requested review from
mikeproeng37,
mjc1283 and
thomaszurkan-optimizely
mikeproeng37
suggested changes
Jan 23, 2020
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
Mostly ok, just have a suggestion
aliabbasrizvi
approved these changes
Jan 23, 2020
|
|
||
| if !inSlice(datafileVersions, datafile.Version) { | ||
| err = errors.New("unsupported datafile version") | ||
| logger.Error(fmt.Sprintf("Version %s of datafile not supported", datafile.Version), err) |
Contributor
There was a problem hiding this comment.
Will be useful to say unable to initialize/update or something along those lines.
mikecdavis
approved these changes
Jan 23, 2020
Contributor
mikecdavis
left a comment
mikecdavis
left a comment
There was a problem hiding this comment.
One suggestion to use a map as opposed to a slice based off a SO article. Also standardizing on assert.Error and assert.NoError when checking for errors.
mikeproeng37
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
to be compatible with other sdk's, we are adding a check for a valid version of datafile. go-sdk supports only version 4 of datafile, same as the family of more recent sdk's.