Return variables as an interface{} from GetAllFeatureVariables. #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecdavis
force-pushed
the
mikecdavis/OASIS-5905-all-variables-with-type
branch
from
db60fc5 to
8b36ebc
Compare
pawels-optimizely
approved these changes
Jan 24, 2020
Contributor
pawels-optimizely
left a comment
pawels-optimizely
left a comment
There was a problem hiding this comment.
lgtm, if our customers expect that and if this is what other sdk's are doing. probably @mikeng13 or @mjc1283 needs to review that too.
Contributor
|
@pawels-optimizely other SDKs don't offer this API yet. This could be construed as a breaking change though since it is changing the signature. Though I don't feel too strongly about it, just wanna make sure we're ok with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change is also going to be consumed by Agent to be able to provide typed responses.