ci(travis): add mdspell #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juancarlostong
force-pushed
the
jctong/mdspell
branch
from
6c66a67 to
256028a
Compare
| install: | ||
| - npm i -g markdown-spellcheck | ||
| before_script: | ||
| - wget --quiet https://raw.githubusercontent.com/optimizely/mdspell-config/master/.spelling |
Contributor
There was a problem hiding this comment.
I thought we wanted to keep that file locally. Are we going to make a change to this global file all the time?
Contributor
Author
There was a problem hiding this comment.
we want to use global so we dont have to maintain redundant entries for all sdk repos.
eg.
optimizely is special dictionary
should be for every sdk.. lets just put it in one place
Contributor
pawels-optimizely
left a comment
pawels-optimizely
left a comment
There was a problem hiding this comment.
I thought we wanted to keep that file locally. Are we going to make a change to this global file all the time?
pawels-optimizely
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.