fix(httpDispatcher): bug. No logger passed in causing a crash. #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaszurkan-optimizely
requested review from
mikeproeng37 and
pawels-optimizely
mikeproeng37
suggested changes
Apr 22, 2020
pkg/event/dispatcher.go
Outdated
| return success, err | ||
| } | ||
|
|
||
| func NewHttpEventDispatcher(sdkKey string, requester *utils.HTTPRequester, logger logging.OptimizelyLogProducer) Dispatcher { |
Contributor
There was a problem hiding this comment.
Need to be consistent with naming and make HTTP all caps here since you have it for the requester factory method below
mjc1283
approved these changes
Apr 22, 2020
thomaszurkan-optimizely
added a commit
that referenced
this pull request
Apr 22, 2020
* fix httpDispatcher bug. No logger passed in * fix lint error * make Http HTTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.