nit(attribute-validation): Using switch instead of multiple if checks. #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Aug 31, 2022
pkg/event/factory.go
Outdated
| } | ||
| if _, ok := value.(bool); ok { | ||
| switch value.(type) { | ||
| case string, float64, int, bool: |
There was a problem hiding this comment.
Does this change work for float32, int8, which should be accepted?
Contributor
There was a problem hiding this comment.
https://go.dev/tour/basics/11
should give all types?
jaeopt
approved these changes
Aug 31, 2022
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
LGTM
wondering what's wrong with the original if-based one. It'll cover all types.
Contributor
Author
i tried the new tests for both new and previous code, behaviour was the same. We would've required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Tests:
Jira ticket:
https://optimizely.atlassian.net/browse/OASIS-8593