feat: Added a generic LRUCache interface and a default implementation #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
approved these changes
Oct 5, 2022
| } | ||
|
|
||
| // NewLRUCache returns a new instance of Least Recently Used in-memory cache | ||
| func NewLRUCache(size int, timeoutInSecs int64) LRUCache { |
There was a problem hiding this comment.
int64 to int? Range will be less than ~10000
Contributor
Author
There was a problem hiding this comment.
To avoid converting timeoutInSecs to in64 every time isValid is called since time.Now().Unix() returns a int64 value and calculations are only allowed between values of similar type's.
msohailhussain
approved these changes
Oct 19, 2022
Contributor
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
please address my comments and lgtm!!!
| Reset() | ||
| } | ||
|
|
||
| type cacheElement struct { |
|
|
||
| // Cache is used for caching ODP segments | ||
| type Cache interface { | ||
| Save(key string, value interface{}) |
Contributor
There was a problem hiding this comment.
can we add specific type of interface instead of interface{}
Contributor
Author
There was a problem hiding this comment.
interface has no further types in go.
| l.lock.Lock() | ||
| defer l.lock.Unlock() | ||
| if item, ok := l.items[key]; !ok { | ||
| if l.maxSize == len(l.items) { |
Contributor
There was a problem hiding this comment.
add comment. what this logic does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Included new tests in the test project
Issues
FSSDK-8513