feat(integrations): Added support for integrations in datafile and evaluation. #350
Conversation
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
partial review. need to check matcher conditions code.
| "fmt" | ||
| "time" | ||
|
|
||
| "github.com/optimizely/go-sdk" |
There was a problem hiding this comment.
This was forced by linter since we are using optimizely keyword to access the package in the sample code.
| return attributesCopy | ||
| } | ||
|
|
||
| func copyQualifiedSegments(qualifiedSegments []string) (qualifiedSegmentsCopy []string) { |
There was a problem hiding this comment.
need to check offline.
|
|
||
| import ( | ||
| "io/ioutil" | ||
| "os" |
There was a problem hiding this comment.
why this is changed?
There was a problem hiding this comment.
Suggested by linter as "io/ioutil is now depreceated in go 1.16 onwards.
| var hostForODP, publicKeyForODP string | ||
| if len(datafile.Integrations) > 0 { | ||
| integration := datafile.Integrations[0] | ||
| if integration.Key == "odp" { |
There was a problem hiding this comment.
This seems weird, can we 'iterate integrationsand checkodp, assign it and get out of loop`
| experimentIDMap, experimentKeyMap := mappers.MapExperiments(allExperiments, experimentGroupMap) | ||
|
|
||
| rollouts, rolloutMap := mappers.MapRollouts(datafile.Rollouts) | ||
| integrations := mappers.MapIntegrations(datafile.Integrations) |
There was a problem hiding this comment.
is this map? integrationsMap?
| ) | ||
|
|
||
| // MapIntegrations maps the raw datafile integration entities to SDK Integration entities | ||
| func MapIntegrations(integrations []datafileEntities.Integration) (integrationsList []entities.Integration) { |
There was a problem hiding this comment.
This is not a map, simple list either return map along with list or no need of this method.
| reasons := decide.NewDecisionReasons(options) | ||
| if condition.Type != customAttributeType { | ||
| isValid := false | ||
| for _, validType := range validTypes { |
There was a problem hiding this comment.
we have two valid types that we support now, this can be seen here: https://github.com/optimizely/go-sdk/pull/350/files#diff-4b69e47626e15aedb2e8d1bb3b34fdb04fd57af036e7c00f9f968a5490d24750R35
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks great. A few changes suggested.
| if qualifiedSegments == nil { | ||
| qualifiedSegments = []string{} | ||
| } |
There was a problem hiding this comment.
qualifiedSegments are nullable. When null, it indicates non-determined (fetchSegments are not completed yet). Empty segments is valid one (fetchSegments returns an empty list).
| return OptimizelyUserContext{ | ||
| UserID: userID, | ||
| Attributes: attributesCopy, | ||
| qualifiedSegments: []string{}, |
There was a problem hiding this comment.
Why passing empty array instead of a copy of current qualifiedSegments?
| type DatafileProjectConfig struct { | ||
| datafile string | ||
| hostForODP string | ||
| publicKeyForODP string |
There was a problem hiding this comment.
I see that a logic to get all segments used in datafile audiences is missing. We need it later when we call fetchSegments. See https://github.com/optimizely/swift-sdk/blob/ec83c87d53b17ea58f8c73eb581b27fa52b6305c/Sources/Data%20Model/ProjectConfig.swift#L151
There was a problem hiding this comment.
I was originally holding it off for the next PR but have now implemented it in this one. Please have a look at the new changes.
2. Suggested changes made.
| audience.ConditionTree = conditionTree | ||
| } | ||
|
|
||
| for _, s := range fSegments { |
There was a problem hiding this comment.
please add comments.
Summary
integrationssection of the datafileEvaluate()using UserContextTest plan
Issues
FSSDK-8518