chore: Prepare release branch for new release #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
requested review from
thomaszurkan-optimizely and
aliabbasrizvi
thomaszurkan-optimizely
suggested changes
Sep 21, 2018
aliabbasrizvi
approved these changes
Sep 21, 2018
|
Looks like compat failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This cherry-picks #214 and #215 into the 2.1.x release branch.
Tests
The Compat Suite runs on the latest version of the testapp, which is built from the master branch and already has changes to support the 3.0 release. Therefore, this particular release branch compile with that testapp version and we can't run the compat suite tests on it.
Instead, I've checked out a different branch of the testapp and ran the compat suite tests locally against this PR.