-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Allowing Empty UserID as valid field #220
Conversation
Pull Request Test Coverage Report for Build 773
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But, I still question whether we should allow empty user ids as valid.
@thomaszurkan-optimizely Yes there are testcases of checking empty user id as valid added in fullstack compatibility suite. @mikeng13 can you please elaborate further. |
Yeah we decided at some point to allow empty strings as they are a valid way to use the API. They result in a valid bucketing number and kind of serves as a way to allow binary ON/OFF usage of APIs like |
No description provided.