Skip to content

(fix) have the buffer reader call wrapped in a try catch in case of exception #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2018
Merged

(fix) have the buffer reader call wrapped in a try catch in case of exception #241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eb52ff
have the buffer reader call wrapped in a try catch in case of exception
thomaszurkan-optimizely Nov 26, 2018
4626303
Merge branch 'master' into fixExceptionBuilerVersion
thomaszurkan-optimizely Nov 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions core-api/src/main/java/com/optimizely/ab/event/internal/BuildVersionInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,22 @@ public final class BuildVersionInfo {

public final static String VERSION = readVersionNumber();
private static String readVersionNumber() {
BufferedReader bufferedReader =
new BufferedReader(
new InputStreamReader(BuildVersionInfo.class.getResourceAsStream("/optimizely-build-version"),
Charset.forName("UTF-8")));
BufferedReader bufferedReader = null;
try {
bufferedReader =
new BufferedReader(
new InputStreamReader(BuildVersionInfo.class.getResourceAsStream("/optimizely-build-version"),
Charset.forName("UTF-8")));

return bufferedReader.readLine();
} catch (Exception e) {
logger.error("unable to read version number");
return "unknown";
} finally {
try {
bufferedReader.close();
if (bufferedReader != null) {
bufferedReader.close();
}
} catch (Exception e) {
logger.error("unable to close reader cleanly");
}
Expand Down