Skip to content

Feat: Added SetDatafileAccessToken method in OptimizelyFactory #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2020
Merged

Feat: Added SetDatafileAccessToken method in OptimizelyFactory #384

merged 4 commits into from
Jul 9, 2020

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Jul 9, 2020 •
edited by msohailhussain
Loading

Summary

  • Adds “OptimizelyFactory#setDatafileAccessToken(string) method
  • Removed spell checker.

Test plan

  • Added unit tests and other unit tests should pass and all FSC scenarios should pass

@mnoman09 mnoman09 requested a review from a team as a code owner July 9, 2020 13:19
@mnoman09 mnoman09 removed their assignment Jul 9, 2020
@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1447

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 89.484%
Totals Coverage Status
Change from base Build 1437: 0.01%
Covered Lines: 3957
Relevant Lines: 4422
💛 - Coveralls

aliabbasrizvi
aliabbasrizvi reviewed Jul 9, 2020
View reviewed changes
core-httpclient-impl/src/test/java/com/optimizely/ab/OptimizelyFactoryTest.java Outdated
Comment on lines 183 to 185
String expected = "datafile-access-token";
OptimizelyFactory.setDatafileAccessToken(expected);
assertEquals(expected, PropertyUtils.get(HttpProjectConfigManager.CONFIG_DATAFILE_AUTH_TOKEN));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have already tested this previously. Why here? This can be removed.

aliabbasrizvi
aliabbasrizvi suggested changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR may not be needed.

mikecdavis
mikecdavis reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature request was to maintain consistency and support for these global setters to override system parameters. They are convenience methods so not strictly necessary, but they add visibility/discoverability as well so I see no harm in adding them. That being said, as a very minimum we should update the README.md

@mnoman09
Added datafileAuthToken in readme
96a8372 
removed extra line of authtoken test
@mnoman09 mnoman09 removed their assignment Jul 9, 2020
mikecdavis
mikecdavis approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliabbasrizvi aliabbasrizvi merged commit 24205e9 into master Jul 9, 2020
@aliabbasrizvi aliabbasrizvi deleted the mnoman/oasis-6755 branch July 9, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecdavis mikecdavis mikecdavis approved these changes

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnoman09 @coveralls @mikecdavis @aliabbasrizvi @msohailhussain