feat: Add datafile accessor #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1500
💛 - Coveralls |
|
unit test missing. toDatafile |
| @@ -436,6 +443,7 @@ public Audience getAudience(String audienceId) { | |||
| public String toString() { | |||
| return "ProjectConfig{" + | |||
| "accountId='" + accountId + '\'' + | |||
| ", datafile='" + datafile + '\'' + | |||
There was a problem hiding this comment.
Don't add it in toString.
@mikeng13 @mjc1283 what do you suggest?
removed datafile from to string
jaeopt
requested changes
Aug 25, 2020
core-api/src/main/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfig.java
Outdated
Show resolved
Hide resolved
core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java
Outdated
Show resolved
Hide resolved
core-api/src/main/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfig.java
Outdated
Show resolved
Hide resolved
jaeopt
reviewed
Aug 26, 2020
| @@ -27,8 +26,6 @@ | |||
| private Map<String, OptimizelyExperiment> experimentsMap; | |||
| private Map<String, OptimizelyFeature> featuresMap; | |||
| private String revision; | |||
|
|
|||
| @JsonIgnore | |||
There was a problem hiding this comment.
I meant to remove @JsonIgnore redundant below at "getDatafile()".
Is it ok to remove @JsonIgnore for datafile completely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://travis-ci.com/github/optimizely/fullstack-sdk-compatibility-suite/builds/181371500