Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add Optimizely builder option for client-engine info #466

Merged
merged 6 commits into from
Mar 15, 2022
Merged

fix: add Optimizely builder option for client-engine info #466

merged 6 commits into from
Mar 15, 2022

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Mar 9, 2022

Summary

  • Add an option to specify client-engine version (android-sdk, etc) in the Optimizely builder.

Test plan

  • Add a unit test for builder with client-engine version.

Issues

  • OASIS-8188

@jaeopt jaeopt requested a review from a team as a code owner March 9, 2022 18:05
@coveralls
Copy link

coveralls commented Mar 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1965

  • 12 of 12 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 90.806%
Totals Coverage Status
Change from base Build 1962: 0.05%
Covered Lines: 4889
Relevant Lines: 5384
💛 - Coveralls

@jaeopt jaeopt removed their assignment Mar 9, 2022
msohailhussain
msohailhussain reviewed Mar 14, 2022
View reviewed changes
core-api/src/main/java/com/optimizely/ab/event/internal/BuildVersionInfo.java
public final static String VERSION = readVersionNumber();

// can be overridden by other wrapper client (android-sdk, etc)

private static String clientVersion = readVersionNumber();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike the old VERSION, this private variable can be changed with Optimizely.Builder.

msohailhussain
msohailhussain reviewed Mar 14, 2022
View reviewed changes
core-api/src/test/java/com/optimizely/ab/OptimizelyBuilderTest.java

eventHandler = mock(EventHandler.class);
optimizely = Optimizely.builder(validConfigJsonV4(), eventHandler)
.withClientInfo(EventBatch.ClientEngine.ANDROID_SDK, "1.2.3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it confusing to check "android-sdk" client engine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify this comment? Not clear to me.

msohailhussain
msohailhussain approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit 336b610 into master Mar 15, 2022
@jaeopt jaeopt deleted the jae/event-version branch March 15, 2022 15:44
@jaeopt jaeopt mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaeopt @coveralls @msohailhussain @optimizely-codereview-bot