Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-8953] update non-code-path resources for FX #506

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Mar 10, 2023

Summary

Update all non-code-path SDK resources for Feature Experimenation

Test plan

  • Pass all tests

Issues

Copy link

@russell-loube-optimizely russell-loube-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please have fellow dev approve.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
[![Build Status](https://travis-ci.org/optimizely/java-sdk.svg?branch=master)](https://travis-ci.org/optimizely/java-sdk)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add coveralls badge if easy to do so, or create a follow-up story

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this new line is causing the two badges you current have to appear on two lines. Please remove so that they're all on the same line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add coveralls badge if easy to do so, or create a follow-up story

Coverall links disconnected for some SDKs including java. Let's review them all together. @russell-loube-optimizely

Copy link

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 989cf3f into master Mar 10, 2023
@jaeopt jaeopt deleted the jae/fix-readme branch March 10, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants