Skip to content

[FSSDK-9422] fix(AsyncEventHandler): add evict timeout to logx connections #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Jun 5, 2023

Summary

Sporadic logx event discards reported. A staled connections after a long idle time may be one of the culprits.
Max connection idle time of 1min is added to AsyncEventHandler, after which connection is forced-closed.

Test plan

  • pass all existing tests.

Issues

  • FSSDK-9422

@jaeopt jaeopt requested a review from a team as a code owner June 5, 2023 22:40
@jaeopt jaeopt removed their assignment Jun 5, 2023
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 7ca4df3 into master Jun 6, 2023
@jaeopt jaeopt deleted the jae/logx-evict branch June 6, 2023 20:31
jaeopt added a commit that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants