Skip to content

[Bug] Restore exported types defined in shared_types #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
avifoxi opened this issue Oct 7, 2020 · 1 comment · Fixed by #594
Closed

[Bug] Restore exported types defined in shared_types #593

avifoxi opened this issue Oct 7, 2020 · 1 comment · Fixed by #594

Comments

@avifoxi
Copy link

avifoxi commented Oct 7, 2020

What I wanted to do

Continue to use exported types defined in https://github.com/optimizely/javascript-sdk/blob/master/packages/optimizely-sdk/lib/shared_types.ts

These used to be exported from the package. We are maintaining libraries that depend on these types.

Please export them from index.d.ts

What I expected to happen

UserProfileService type should be useable as a named export.
OptimizelyConfig type should be useable as a named export.

What actually happened

These types may be able to be imported - but we have to do it much more indirectly. Please continue to just export them.
@mjc1283 mjc1283 mentioned this issue Oct 7, 2020
Merged
@mjc1283 mjc1283 linked a pull request Oct 7, 2020 that will close this issue
fix(TS type defs): Restore missing types #594
Merged
mjc1283 added a commit that referenced this issue Oct 7, 2020
@mjc1283 @yavorona
fix(TS type defs): Restore missing types (#594)
e47db45 
Summary:

UserProfileService and several other types were removed by mistake from lib/index.d.ts.

Test plan:

Manual testing

Issues:

#593

Co-authored-by: Polina Nguen <polina.nguen@optimizely.com>
@mjc1283
Copy link
Contributor

mjc1283 commented Oct 7, 2020

@avifoxi FYI, we are planning to do another release shortly, containing the changes in #594.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(TS type defs): Restore missing types optimizely/javascript-sdk
2 participants
@mjc1283 @avifoxi