Typescript - logLevel property on createInstance config is incorrect

[jrbarnard]

What I wanted to do

Use createInstance in typescript

What I expected to happen

For the types to support LogLevel | string

What actually happened

The createInstance Config logLevel property type is incorrect. It type hints just the LogLevel enum, but it also supports a string representation of the log level which will be coerced at runtime.

Reference to types that need changing:

• javascript-sdk/packages/optimizely-sdk/lib/index.d.ts

  Line 71 in e0158e5

  logLevel?:

• javascript-sdk/packages/optimizely-sdk/lib/shared_types.ts

  Line 99 in e0158e5

  logLevel?: LogLevel;

Steps to reproduce

Set up a typescript project with the optimizely sdk and attempt to use createInstance with a string logLevel.
If you cast it and run the code it will work as expect. But the type does not support the string logLevel if not casted.

[mjc1283]

Thanks @jrbarnard. Agree with your assessment - will fix this.

[yavorona]

@jrbarnard Thanks again for reporting this issue. We merged #627 fix and released it in v4.4.2