Fix package description to reflect new Optimizely X product. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraja2
approved these changes
Oct 6, 2016
mjc1283
added a commit
that referenced
this pull request
Apr 22, 2019
… constructor, add onReady method (#13) Summary: - Import and use datafile manager package. Create datafile manager instance in Optimizely constructor if `sdkKey`. is provided. - Provide `onReady` method, returning a promise based on the datafile manager's `onReady` method, or a fulfilled promise if no `sdkKey` was provided. - Update `isValidInstance` to distinguish between config validity and datafile/project config validity. - Move some validation/creation logic into a new function in the project config module: `tryCreatingProjectConfig` - Return early in top-level methods when `configObj` is not available Test plan: Unit tests Issues: https://optimizely.atlassian.net/browse/OASIS-4384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@optimizely/fullstack-devs