chore(contrib): Add PR template and commit message guidelines. #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
requested review from
aliabbasrizvi,
thomaszurkan-optimizely and
mjc1283
spencerwilson-optimizely
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Should there be directions to fork the repo? Since most folks that need to read CONTRIBUTING.md won't have write access to the repo, should we include a step to fork the repo? (and say 'open a PR from your fork into the master branch of the original repo', or something like that)
aliabbasrizvi
approved these changes
Nov 6, 2018
|
Good point @spencerwilson-optimizely, I'll add that before merging. |
spencerwilson-optimizely
deleted the
mng/amend-contributing-guidelines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CONTRIBUTING.md