Skip to content

fix(set-forced-variation): Treats empty variation key as invalid and does not reset variation. #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2018
Merged

fix(set-forced-variation): Treats empty variation key as invalid and does not reset variation. #185

merged 2 commits into from
Nov 13, 2018

Conversation

mfahadahmed
Copy link
Contributor

Summary

  • Forced variation key passed as an empty String will be considered as invalid.
  • Added unit test for empty string variation key.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.328% when pulling 142b98b on fahad/invalid-forced-variation-key into 42eb08e on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.328% when pulling 142b98b on fahad/invalid-forced-variation-key into 42eb08e on master.

mikeproeng37
mikeproeng37 approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 2a47e5e into master Nov 13, 2018
@oakbani oakbani deleted the fahad/invalid-forced-variation-key branch November 14, 2018 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfahadahmed @coveralls @mikeproeng37