feat(attribute_value): Don't target NAN, INF, -INF and > 2^53. #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
suggested changes
Dec 26, 2018
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.tests.js
Show resolved
Hide resolved
nchilada
suggested changes
Dec 26, 2018
| @@ -24,7 +25,9 @@ module.exports = { | |||
| }, | |||
| isArray: require('lodash/isArray'), | |||
| isEmpty: require('lodash/isEmpty'), | |||
| isFinite: require('lodash/isFinite'), | |||
| isFinite: function(number) { | |||
| return finite(number) && Math.abs(number) <= Math.pow(2, 53); | |||
There was a problem hiding this comment.
Suggested change
| return finite(number) && Math.abs(number) <= Math.pow(2, 53); | |
| return finite(number) && Math.abs(number) <= Number.MAX_SAFE_INTEGER + 1; |
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.tests.js
Show resolved
Hide resolved
| 'boolean_key': false, | ||
| 'browser_type': Infinity, | ||
| 'integer_key': NaN, | ||
| 'boolean_key': (Math.pow(2, 53) + 2) * -1, | ||
| 'double_key': [1, 2, 3], |
There was a problem hiding this comment.
Nit: strange attribute keys 🤔
There was a problem hiding this comment.
I think we should continue including some valid attributes so that we can make sure they're kept even when other attributes are filtered out? For example
'browser_type': 'Chrome',
'valid_positive_number': Math.pow(2, 53),
'valid_negative_number': -Math.pow(2, 53),
'invalid_number': Math.pow(2, 53) + 2,
'array': [1, 2, 3]and then assert that only the first three are accepted
| 'browser_type': -Infinity, | ||
| 'integer_key': NaN, | ||
| 'boolean_key': Math.pow(2, 53) + 2, | ||
| 'double_key': [1, 2, 3], |
There was a problem hiding this comment.
Same suggestion - we should include some valid attribute values too
nchilada
approved these changes
Dec 28, 2018
mikeproeng37
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't target NAN, INF or -INF doubles
Don't target Values > 2^53.
Modified fns.isFinite to check if the number is greater than 2^53.
Test plan
Issues