Skip to content

fix(decision_service): Return null variation if experiment key does not exist in feature's experimentIds array. #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2019
Merged

fix(decision_service): Return null variation if experiment key does not exist in feature's experimentIds array. #206

merged 2 commits into from
Jan 11, 2019

Conversation

mfahadahmed
Copy link
Contributor

Summary

  • Return null variation if experiment key does not exist in feature's experimentIds array.

Issues

  • "OASIS-3950"

@coveralls
Copy link

coveralls commented Jan 9, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 97.266% when pulling 8d0e0b6 on fahad/decision-service-fix into 7fe2e0e on master.

@msohailhussain msohailhussain requested a review from a team January 9, 2019 20:28
mikeproeng37
mikeproeng37 suggested changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just one nit

packages/optimizely-sdk/lib/core/decision_service/index.tests.js Outdated
sinon.assert.calledWithExactly(mockLogger.log, LOG_LEVEL.DEBUG, 'DECISION_SERVICE: User user1 is not in any experiment on the feature feature_with_group.');
});

it('bucketed group experiment does not exist in the feature', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wording does not conform the BDD pattern. Should be it(returns null decision for group experiment not referenced by the feature)

mikeproeng37
mikeproeng37 approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit cfea9ce into master Jan 11, 2019
@mikeproeng37 mikeproeng37 deleted the fahad/decision-service-fix branch January 14, 2019 21:12
oakbani pushed a commit that referenced this pull request Apr 17, 2019
@mfahadahmed @oakbani
fix(decision_service): Return null variation if experiment key does n…
661ca6b 
…ot exist in feature's experimentIds array. (#206)

(cherry picked from commit cfea9ce)
@rashidsp rashidsp mentioned this pull request Apr 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfahadahmed @coveralls @mikeproeng37