fix(decision_service): Return null variation if experiment key does not exist in feature's experimentIds array. #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot exist in feature's experimentIds array.
mikeproeng37
suggested changes
Jan 10, 2019
| @@ -889,6 +889,18 @@ describe('lib/core/decision_service', function() { | |||
| assert.deepEqual(decision, expectedDecision); | |||
| sinon.assert.calledWithExactly(mockLogger.log, LOG_LEVEL.DEBUG, 'DECISION_SERVICE: User user1 is not in any experiment on the feature feature_with_group.'); | |||
| }); | |||
|
|
|||
| it('bucketed group experiment does not exist in the feature', function() { | |||
There was a problem hiding this comment.
wording does not conform the BDD pattern. Should be it(returns null decision for group experiment not referenced by the feature)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issues