Skip to content

Remove unused json-loader dependency. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2016
Merged

Remove unused json-loader dependency. #21

merged 1 commit into from
Nov 17, 2016

Conversation

mikeproeng37
Copy link
Contributor

@optimizely/fullstack-devs

haleybash-optimizely
haleybash-optimizely approved these changes Nov 17, 2016
View reviewed changes
Copy link
Contributor

@haleybash-optimizely haleybash-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeproeng37 mikeproeng37 merged commit ee7a103 into devel Nov 17, 2016
@mikeproeng37 mikeproeng37 deleted the mng/clean-up-json-dep branch November 17, 2016 18:39
mjc1283 added a commit that referenced this pull request Apr 22, 2019
@mjc1283
fix (project config manager): Fix onUpdate dispose function (#21)
6c1b014 
Summary:

Fix dispose function returned from onUpdate of ProjectConfigManager. I forgot to bind the dispose function.

Test plan:

Added new unit test. Manually tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haleybash-optimizely haleybash-optimizely haleybash-optimizely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeproeng37 @haleybash-optimizely