Add bower file so we can register with bower registry. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haleybash-optimizely
approved these changes
Nov 17, 2016
mjc1283
added a commit
that referenced
this pull request
Apr 22, 2019
…of project config and into decision service (#24) Summary: This is a solution for persisting forced variation state when the project config is updated from datafile management. Just as in Java, we moved the forced variation map and forced variation methods into decision service. Test plan: - Existing unit tests are passing with no substantial changes: the changes I made in existing unit tests only update log message assertions to reflect the new location of forced variation methods (previously in project config, now in decision service). - I moved forced variation method tests to the decision service tests file, and updated the method signatures to remove the logger argument (decision service already has a reference to its own logger). - I added a few more unit tests covering cases where a previously set variation or experiment no longer exists on a new project config object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@optimizely/fullstack-devs