fix: Update TypeScript definitions for datafile management #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
changed the title
mikeproeng37
approved these changes
May 2, 2019
| @@ -15,13 +15,35 @@ | |||
| */ | |||
|
|
|||
| declare module '@optimizely/optimizely-sdk' { | |||
| import enums = require('@optimizely/optimizely-sdk/lib/utils/enums'); | |||
| export namespace enums { | |||
| enum LOG_LEVEL { | |||
There was a problem hiding this comment.
Thanks for adding this!
| // The options object given to Optimizely.createInstance. | ||
| export interface Config { | ||
| datafile: object; | ||
| datafile?: object | string; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update TypeScript definitions to account for new methods (
onReady,close) and new properties on object accepted bycreateInstance(datafileOptions,sdkKey)Test plan
Manually tested
Issues
https://optimizely.atlassian.net/browse/OASIS-4559