Skip to content

fix (datafile management): Update polling behavior #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2019
Merged

fix (datafile management): Update polling behavior #266

merged 4 commits into from
May 8, 2019

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented May 8, 2019

Summary

  • When autoUpdate is true, start the timer for the following request immediately, instead of waiting for the response to start the timer
  • When the timeout fires before the response is received, wait for the response to complete and then start the next request immediately. This ensures there is at most 1 request in flight at any time.

Test plan

Added new unit tests. Manually tested.

Issues

https://optimizely.atlassian.net/browse/OASIS-4628

@mjc1283 mjc1283 requested review from mikeproeng37 and a team May 8, 2019 18:36
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.58% when pulling 0c8cb48 on mcarroll/schedule-fix-simple into 27f4159 on master.

@mjc1283 mjc1283 merged commit 39c3b2d into master May 8, 2019
@mjc1283 mjc1283 deleted the mcarroll/schedule-fix-simple branch May 8, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @mikeproeng37