feat(datafile manager): Add request timeouts #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
May 9, 2019 10:53
access to timeout property on fake XHR.
mikeproeng37
suggested changes
May 10, 2019
| @@ -25,12 +25,12 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@types/jest": "^24.0.9", | |||
| "@types/nise": "^1.4.0", | |||
| const scope = nock(host) | ||
| .get(path) | ||
| .delay(61000) | ||
| .reply(200, '{"foo":"bar"}') |
There was a problem hiding this comment.
nit: do you actually need to reply if it's gunna just time out
There was a problem hiding this comment.
Not sure how to implement this test without calling reply. From what I can tell, the 'request' event is not emitted on the scope object when I don't call reply.
| @@ -21,3 +21,5 @@ export const MIN_UPDATE_INTERVAL = 1000 | |||
| export const DEFAULT_URL_TEMPLATE = `https://cdn.optimizely.com/datafiles/%s.json` | |||
|
|
|||
| export const BACKOFF_BASE_WAIT_SECONDS_BY_ERROR_COUNT = [0, 8, 16, 32, 64, 128, 256, 512] | |||
|
|
|||
| export const REQUEST_TIMEOUT_MS = 60 * 1000 // 1 minute | |||
There was a problem hiding this comment.
nit: DEFAULT_REQUEST_TIME_MS?
| const timeout = setTimeout(() => { | ||
| request.abort() | ||
| reject(new Error('Request timed out')) | ||
| }, REQUEST_TIMEOUT_MS) |
There was a problem hiding this comment.
I think we should make this configurable and have it injected in by the datafile manager. That we this doesn't have to rely directly on the config file
There was a problem hiding this comment.
Chatted offline about doing this as a later refactor to keep the scope of this small.
mikeproeng37
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a 60 second timeout to all requests made by the datafile manager. In the browser, we assign to the
timeoutproperty of the XHR. In node, we set our own timeout, and abort the request when the timeout fires.The response promise is rejected when the request times out.
Test plan
Manual & unit tests
Issues
https://optimizely.atlassian.net/browse/OASIS-4685