Skip to content

[OASIS-6102]: changed functionality of the JSON schema validator module #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[OASIS-6102]: changed functionality of the JSON schema validator module #437

wants to merge 4 commits into from

Conversation

yavorona
Copy link
Contributor

@yavorona yavorona commented Apr 2, 2020

Summary

  • Changed functionality of the JSON schema validator module to only validate against projectConfigSchema
  • Updated existing unit tests to reflect this change.

Test plan

Existing unit tests

Issues

OASIS-6102

yavorona added 4 commits March 31, 2020 18:15
@yavorona
Summary:
57de887 
 - Changed validate method to except jsonObject only in json_schema_validator/index.js
Test:
 - Updated test to pass
@yavorona
Address Matt's comments
c1373d8
@yavorona
Eliminate extraneous spaces
3daec78
@yavorona
Remove unnecessary imports
ba8a5c0
@yavorona yavorona requested a review from a team as a code owner April 2, 2020 01:11
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 97.218% when pulling ba8a5c0 on yavorona:pnguen/OASIS-6102 into 645ea8a on optimizely:master.

@yavorona yavorona closed this Apr 2, 2020
@yavorona
Copy link
Contributor Author

yavorona commented Apr 2, 2020

Closing and opening a new one instead: #438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yavorona yavorona

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yavorona @coveralls