feat: Added project_config_manager interface #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorona
force-pushed
the
pnguen/project_config_manager_interface
branch
2 times, most recently
from
a157626 to
32576f4
Compare
mjc1283
suggested changes
Sep 23, 2020
| * Returns the optimizely config object | ||
| * @return {ProjectConfig} | ||
| */ | ||
| getOptimizelyConfig(): ProjectConfig; |
There was a problem hiding this comment.
Comment is wrong - this returns an OptmizelyConfig
There was a problem hiding this comment.
You are right, thanks! It is a totally different OptimizelyConfig object. I updated the comments and the interface as well.
| * Stop the internal datafile manager and remove all update listeners | ||
| * @return {Promise|void} | ||
| */ | ||
| stop(): Promise<void> | void; |
There was a problem hiding this comment.
Looks like it never returns a promise, just void.
yavorona
force-pushed
the
pnguen/project_config_manager_interface
branch
from
32576f4 to
a9b71e4
Compare
mjc1283
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
project_config_managerinterfaceTests